diff --git a/.github/workflows/build-connector-command.yml b/.github/workflows/build-connector-command.yml index 4ea3f232b2dc..e458dedbb8bb 100644 --- a/.github/workflows/build-connector-command.yml +++ b/.github/workflows/build-connector-command.yml @@ -135,6 +135,12 @@ jobs: run: | source venv/bin/activate ci_credentials ${{ github.event.inputs.connector }} + # normalization also runs destination-specific tests, so fetch their creds also + if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ]; then + ci_credentials destination-bigquery + ci_credentials destination-postgres + ci_credentials destination-snowflake + fi env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} # TODO: seems like this should run in post-merge workflow diff --git a/.github/workflows/publish-command.yml b/.github/workflows/publish-command.yml index afc297e67df8..807aeb314e1b 100644 --- a/.github/workflows/publish-command.yml +++ b/.github/workflows/publish-command.yml @@ -266,6 +266,12 @@ jobs: run: | source venv/bin/activate ci_credentials ${{ matrix.connector }} + # normalization also runs destination-specific tests, so fetch their creds also + if [ 'bases/base-normalization' = "${{ matrix.connector }}" ]; then + ci_credentials destination-bigquery + ci_credentials destination-postgres + ci_credentials destination-snowflake + fi env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} - name: Set Name and Version Environment Vars diff --git a/.github/workflows/test-command.yml b/.github/workflows/test-command.yml index 66bcf10f782d..1b00e6e649a6 100644 --- a/.github/workflows/test-command.yml +++ b/.github/workflows/test-command.yml @@ -110,6 +110,12 @@ jobs: run: | source venv/bin/activate ci_credentials ${{ github.event.inputs.connector }} + # normalization also runs destination-specific tests, so fetch their creds also + if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ]; then + ci_credentials destination-bigquery + ci_credentials destination-postgres + ci_credentials destination-snowflake + fi env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} diff --git a/.github/workflows/test-performance-command.yml b/.github/workflows/test-performance-command.yml index f87987fccd19..27c3264c6861 100644 --- a/.github/workflows/test-performance-command.yml +++ b/.github/workflows/test-performance-command.yml @@ -116,6 +116,12 @@ jobs: run: | source venv/bin/activate ci_credentials ${{ github.event.inputs.connector }} + # normalization also runs destination-specific tests, so fetch their creds also + if [ 'bases/base-normalization' = "${{ github.event.inputs.connector }}" ]; then + ci_credentials destination-bigquery + ci_credentials destination-postgres + ci_credentials destination-snowflake + fi env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} - run: | diff --git a/airbyte-integrations/bases/base-normalization/build.gradle b/airbyte-integrations/bases/base-normalization/build.gradle index 0991372cd203..65cbb49440fa 100644 --- a/airbyte-integrations/bases/base-normalization/build.gradle +++ b/airbyte-integrations/bases/base-normalization/build.gradle @@ -102,6 +102,14 @@ task("customIntegrationTestPython", type: PythonTask, dependsOn: installTestReqs dependsOn ':airbyte-integrations:connectors:destination-clickhouse:airbyteDocker' } +// DATs have some additional tests that exercise normalization code paths, +// so we want to run these in addition to the base-normalization integration tests. +// If you add more items here, make sure to also to have CI fetch their credentials. +// See git history for an example. +integrationTest.dependsOn(":airbyte-integrations:connectors:destination-bigquery:integrationTest") +integrationTest.dependsOn(":airbyte-integrations:connectors:destination-postgres:integrationTest") +integrationTest.dependsOn(":airbyte-integrations:connectors:destination-snowflake:integrationTest") + integrationTest.dependsOn("customIntegrationTestPython") customIntegrationTests.dependsOn("customIntegrationTestPython")