From c7dde44d060f5d1e02da04260a00ea2654c9237b Mon Sep 17 00:00:00 2001 From: Joey Marshment-Howell Date: Tue, 6 Dec 2022 11:52:45 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=AA=9F=20=F0=9F=94=A7=20Add=20comment=20a?= =?UTF-8?q?bout=20feature/experiment=20usage=20(#20123)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- airbyte-webapp/src/hooks/services/Experiment/experiments.ts | 2 ++ airbyte-webapp/src/hooks/services/Feature/types.tsx | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/airbyte-webapp/src/hooks/services/Experiment/experiments.ts b/airbyte-webapp/src/hooks/services/Experiment/experiments.ts index afbc1d57e990..9bb39f541302 100644 --- a/airbyte-webapp/src/hooks/services/Experiment/experiments.ts +++ b/airbyte-webapp/src/hooks/services/Experiment/experiments.ts @@ -1,5 +1,7 @@ /* eslint sort-keys: "error" */ /** + * Experiments are short-term flags for A/B testing or staged rollouts of features. + * * When adding a new feature flag in LaunchDarkly to consume in code you'll need to make * sure to update the typing here. */ diff --git a/airbyte-webapp/src/hooks/services/Feature/types.tsx b/airbyte-webapp/src/hooks/services/Feature/types.tsx index a7a252416f69..af4ce8c61921 100644 --- a/airbyte-webapp/src/hooks/services/Feature/types.tsx +++ b/airbyte-webapp/src/hooks/services/Feature/types.tsx @@ -1,3 +1,8 @@ +/** + * FeatureItems are for permanent flags to differentiate features between environments (e.g. Cloud vs. OSS), + * workspaces, specific user groups, etc. + */ + export enum FeatureItem { AllowUploadCustomImage = "ALLOW_UPLOAD_CUSTOM_IMAGE", AllowCustomDBT = "ALLOW_CUSTOM_DBT",