-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation link: Support both domains: OLD docs.airbyte.io
, NEW docs.airbyte.com
#10412
Comments
docs.airbyte.io
-> docs.airbyte.com
docs.airbyte.io
, NEW docs.airbyte.com
docs.airbyte.io
, NEW docs.airbyte.com
docs.airbyte.io
, NEW docs.airbyte.com
cc @airbytehq/frontend |
Can someone explain me what's the difference between those two domains? Which one is the one we're using for actually publishing docs? |
We redirect from .io to .com now. However, the issue here is that we're packaging the doc .md files into the webapp build, but referencing their file paths based off of the Some of the more recent ones are specified with .com:
While others use .io:
Others still use invalid domains:
or helpful but non-internal domains (not related to the md files at all):
So I suppose for some of these you'll need to reach out to the connector team to improve these. However, I agree with @grubberr that we could fix the hacky mapping here to accept either prefix. |
I've created https://github.com/airbytehq/airbyte-internal-issues/issues/438 for the connectors team to fix all invalid scaffolded domains. |
Current Behavior
Docs pre-loading feature works only for OLD urls which starts with
docs.airbyte.io
domain.https://docs.airbyte.io/integrations/sources/zendesk_sunshine
but for NEW correct domain
docs.airbyte.com
it fails like on pictureit happens because we support only OLD domain
airbyte/airbyte-webapp/src/hooks/services/useDocumentation.ts
Line 12 in fe1eb8d
Expected Behavior
I think we need to support both domains:
docs.airbyte.io, docs.airbyte.com
until all doc urls updated.The text was updated successfully, but these errors were encountered: