Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frontmatter header from documentation sidesheet #10491

Closed
timroes opened this issue Feb 21, 2022 · 1 comment · Fixed by #10624
Closed

Remove frontmatter header from documentation sidesheet #10491

timroes opened this issue Feb 21, 2022 · 1 comment · Fixed by #10624
Assignees
@timroes
Labels
type/bug Something isn't working

Comments

@timroes
Copy link
Collaborator

timroes commented Feb 21, 2022

Our documentation markdown uses frontmatter, thus we need to make sure before rendering a documentation in the sidesheet to strip of the frontmatter headers. Currently they are simply rendered into the sidesheet:

screenshot-20220221-092241
@timroes timroes added type/bug Something isn't working area/frontend labels Feb 21, 2022
@timroes timroes mentioned this issue Feb 21, 2022
Closed
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@timroes timroes self-assigned this Feb 24, 2022
@timroes timroes mentioned this issue Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow frontmatter in rendered markdown airbytehq/airbyte
2 participants
@timroes @octavia-squidington-iii