Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source shopify: add balance transactions stream data to testing store #10524

Closed
harshithmullapudi opened this issue Feb 22, 2022 · 15 comments
Closed

Comments

@harshithmullapudi
Copy link
Contributor

Add balance transactions stream in our testing store as the tests are failing. This will close #9850

@harshithmullapudi
Copy link
Contributor Author

@igrankova can you help here? Is this possible?

@igrankova
Copy link
Contributor

Hi, @harshithmullapudi, let me find out what can I do.

@igrankova
Copy link
Contributor

@harshithmullapudi can you specify what account should I update?

@harshithmullapudi
Copy link
Contributor Author

Hey I think shop airbyte-integration-test is what we are using right now

@igrankova
Copy link
Contributor

Thank you, I'm in.

@igrankova
Copy link
Contributor

@harshithmullapudi, I tried to create some transactions and faced with the problem to emulate payments for the test orders, so I contacted to the support and they are trying to find out some steps to fix the checkouts in the online store. I guess when this problem is solved, I could make several payments which should change the balance and we could have needed balance transactions in our dev environment. I'll inform you about the progress.

@igrankova
Copy link
Contributor

@harshithmullapudi still working on it, today I've created and paid orders, but I don't see the Balance Transactions changed after that. I'm finding out how to create these transactions with the support team.

@igrankova
Copy link
Contributor

@harshithmullapudi, hi! Can you check the tests? Has anything changed with the Balance Transactions? If not, please specify more details for the support team.

@harshithmullapudi
Copy link
Contributor Author

Hey sorry for late reply will check and update in some time

@igrankova
Copy link
Contributor

@harshithmullapudi, can you answer this question from the Shopify support?
"let me know an estimate of how many transactions you will need to process for the purpose of testing your API? "
They are trying to help us with transactions for testing

@harshithmullapudi
Copy link
Contributor Author

Hey I tried running the tests now bit looks like we are having some trouble with API rate limiting but anyways having transactions more than 10 or so is a good place to be

@igrankova
Copy link
Contributor

igrankova commented Mar 16, 2022

@harshithmullapudi hi, I received an answer from the support: "Your store is now able to process up to 25 Orders for testing your integration on airbyte-integration-test.myshopify.com"
I've accessed the account, as I understand, you need Transactions? https://shopify.dev/api/admin-rest/2021-10/resources/transactions#top
I'm trying to find out how to create them. Can you check the ones I made earlier? I've paid the orders from the store with the test payments. I'm not sure these are the ones you need. If not, I'll try to search for the other way to create Transactions.

@igrankova
Copy link
Contributor

@harshithmullapudi Hi! I've received the instructions from the support team and made several test payments. I kindly ask you to check transactions, can I do anything else for this task?

@harshithmullapudi
Copy link
Contributor Author

@igrankova I ran and it still says the same AssertionError: All streams should return some records, streams without records: ***'balance_transactions'*** did we verify if the API is returning results?

@bazarnov
Copy link
Collaborator

@harshithmullapudi
Based on the Shopify Documentation (REST API):

  • you need to have the payout_id first, which means you need to implement another parent stream to fetch the Payouts.
    see this article for Payouts stream.
  • after you fetched the payouts, you can fetch the balance_transactions by calling the endpoint with the particular payout_id
    see this article for Balance Transactions

I assume that's the main issue you got the empty stream, but this is not related to the issue with the tests, to solve the SAT test issue, you need to add the "empty_streams" property for the balance_transactions stream, which means it could be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants