-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Google Ads Source to Beta #10786
Comments
@misteryeo this is how errors from the "test connection" button get displayed, is this something that needs to be fixed before beta? (note the |
Ooh, thanks for surfacing this @edgao. We should definitely fix this - do you know if this is just how we're parsing the error returned from Google Ads API directly? Or would this parsing issue go across all connectors? @sherifnada feels like we should add this to the checklist when certifying. WDYT? |
If I had to guess, the problem is that because this is rendered as HTML, newlines expressed as WDYT @timroes |
I was more thinking that the connector should extract the error message rather than just converting the raw api response to a string and dumping that into the UI. Haven't looked super closely at this, but it seems doable (and much more in-scope than a UI change) |
@edgao ah got it -- seems simple enough. Works with me |
@sherifnada As you mentioned In this specific case where we're rendering JSON that's now not correctly formatted, I'd go with @edgao: We should try not to have JSON rendered in a string error message. No matter whether we'll get newlines to work or not, this will look horrible in the UI. We should rather shorten it into a human readable error, and if we want to have the full benefit of the JSON still available in the UI, we should have this as a separate field and actually render it dedicated in the UI in some modal/tooltip/etc as advanced information. |
The text was updated successfully, but these errors were encountered: