Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't display data types correctly for date types #11741

Closed
sherifnada opened this issue Apr 5, 2022 · 7 comments · Fixed by #11770
Closed

UI doesn't display data types correctly for date types #11741

sherifnada opened this issue Apr 5, 2022 · 7 comments · Fixed by #11770
Assignees
Labels
area/frontend Related to the Airbyte webapp autoteam needs-triage type/bug Something isn't working type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

The table of supported data types mentioned here is not correctly reflected on the UI.
For example see the schema definition below:

json_schema = {  # Example
            "$schema": "http://json-schema.org/draft-07/schema#",
            "type": "object",
            "properties": {
                "id": {"type": "number"},
                "created_at": {"type": "string", "format": "date-time", "airbyte_type": "timestamp_without_timezone"},
                "updated_at":{"type": "string", "format": "date-time", "airbyte_type": "timestamp_without_timezone"},
                "job": {"type": "string"},
                "company": {"type": "string"},
                "ssn": {"type": "string"},
                "residence": {"type": "string"},
                "current_location": {"type": "array", "items": "number"},
                "blood_group": {"type": "string"},
                "website": {"type": "array", "items": "string"},
                "username": {"type": "string"},
                "name": {"type": "string"},
                "sex": {"type": "string"},
                "address": {"type": "string"},
                "mail": {"type": "string"},
                "birthdate": {"type": "string", "format": "date"},
            },
        }

here is what's shown in the UI
image

The updated_at column, for example, should be shown as a timestamp with timezone as opposed to a string.

Describe the solution you’d like

Correctly display on the UI

cc @evantahler

@sherifnada sherifnada added type/bug Something isn't working type/enhancement New feature or request area/frontend needs-triage labels Apr 5, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@evantahler
Copy link
Contributor

For reference, this was discovered while working on #11738

@sherifnada sherifnada changed the title Update generic connector template to remove usage of deprecated SAT v1 UI doesn't display data types correctly for date types Apr 6, 2022
@krishnaglick krishnaglick self-assigned this Apr 6, 2022
@grishick
Copy link
Contributor

@krishnaglick I noticed that this is still not working correctly for database sources. For example, this field will show as string in the UI:

"event_timestamp":{"type":"string","format":"date-time","airbyte_type":"timestamp_with_timezone"}}}

Screen Shot 2022-08-22 at 6 23 52 PM

@grishick grishick reopened this Aug 23, 2022
@octavia-squidington-iii octavia-squidington-iii added autoteam area/frontend Related to the Airbyte webapp labels Aug 23, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@krishnaglick
Copy link
Contributor

@krishnaglick I noticed that this is still not working correctly for database sources. For example, this field will show as string in the UI:

"event_timestamp":{"type":"string","format":"date-time","airbyte_type":"timestamp_with_timezone"}}}

Screen Shot 2022-08-22 at 6 23 52 PM

The work hadn't been merged, unsure why this was marked as done. I just merged it, please check it out again!

@grishick
Copy link
Contributor

grishick commented Aug 23, 2022

@krishnaglick this issue was likely auto-closed when #11770 was merged:

Screen Shot 2022-08-23 at 8 57 20 AM

is there another PR that is part of fixing this issue?

@krishnaglick
Copy link
Contributor

#14671 is a cousin ticket I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp autoteam needs-triage type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants