Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAT] connector check operation should also be tested in integration tests #12010

Closed
subodh1810 opened this issue Apr 14, 2022 · 2 comments
Closed

[SAT] connector check operation should also be tested in integration tests #12010

subodh1810 opened this issue Apr 14, 2022 · 2 comments
Labels
area/connectors Connector related issues autoteam from/connector-ops needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team team/destinations Destinations team's backlog type/enhancement New feature or request

Comments

@subodh1810
Copy link
Contributor

We recently had an issue where Redshift connector's check command was broken, as a result we were not able to onboard new customers/users. We should make sure to test the connector's check command in integration tests to make sure it gets caught
@subodh1810 subodh1810 added type/enhancement New feature or request area/connectors Connector related issues needs-triage labels Apr 14, 2022
@grishick grishick added from/connector-ops team/destinations Destinations team's backlog team/db-dw-sources Backlog for Database and Data Warehouse Sources team labels Sep 27, 2022
@grishick
Copy link
Contributor

Tagging this issue for all three connector teams.

@evantahler evantahler changed the title connector check operation should also be tested in integration tests [SAT] connector check operation should also be tested in integration tests Sep 28, 2022
@evantahler
Copy link
Contributor

Closing this in favor of #17184 - Once all connectors use SAT, we'll be able to test SPEC, CHECK, etc commands for databases just like we do for API sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues autoteam from/connector-ops needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team team/destinations Destinations team's backlog type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bleonard @evantahler @grishick @sherifnada @subodh1810