Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python CDK: create a way to indicate a stream's default namespace #12492

Closed
sherifnada opened this issue Apr 30, 2022 · 1 comment
Closed

Python CDK: create a way to indicate a stream's default namespace #12492

sherifnada opened this issue Apr 30, 2022 · 1 comment
Labels
CDK Connector Development Kit team/extensibility type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

The Python CDK does not expose an ergonomic way of declaring a stream's namespace.

For example, a class which extends Stream can declare the property primary_key which declares that stream's primary key in the catalog output by that connector. I would similarly like a way to declare the namespace for a stream e.g here is an example of declaring the PK in a stream from Stripe:

class StripeStream(HttpStream, ABC):
    url_base = "https://api.stripe.com/v1/"
    primary_key = "id"

Describe the solution you’d like

I would like to declare the namespace of the stream similarly:

class StripeStream(HttpStream, ABC):
    url_base = "https://api.stripe.com/v1/"
    primary_key = "id"
    namespace = "my_namespace"

This blocks #12491

@sherifnada sherifnada added type/enhancement New feature or request CDK Connector Development Kit team/extensibility labels Apr 30, 2022
@sherifnada sherifnada changed the title Python CDK: create a way to indicate a stream's namespace Python CDK: create a way to indicate a stream's default namespace May 31, 2022
@sherifnada
Copy link
Contributor Author

closed by #13923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit team/extensibility type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant