Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main menu Hover State #12725

Closed
Upmitt opened this issue May 10, 2022 · 2 comments · Fixed by #13762
Closed

Main menu Hover State #12725

Upmitt opened this issue May 10, 2022 · 2 comments · Fixed by #13762
Assignees
@teallarson
Labels
area/frontend Related to the Airbyte webapp autoteam

Comments

@Upmitt
Copy link
Contributor

Upmitt commented May 10, 2022 •
edited
Loading

Add hover state to the main menu's sections:

image

https://www.figma.com/file/AxqFXuHo2BoTY0QY12hxm1/?node-id=5%3A335 - You can click on play to open the prototype and see the behavior

When a user hovers over the item on the main menu, it should hover
@Upmitt Upmitt added type/enhancement New feature or request needs-triage labels May 10, 2022
@octavia-squidington-iii octavia-squidington-iii added autoteam area/frontend Related to the Airbyte webapp labels May 10, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@edmundito edmundito removed their assignment May 11, 2022
@teallarson teallarson self-assigned this Jun 3, 2022
@teallarson teallarson mentioned this issue Jun 3, 2022
Closed
38 tasks
@teallarson teallarson mentioned this issue Jun 14, 2022
Merged
@teallarson
Copy link
Contributor

@Upmitt I have a PR up with the changes we discussed yesterday. The pieces I'm waiting on are:

  1. How to handle the "flyout" menus (Support and Chat)
  2. Settings doesn't have a top-level page (there is no /settings)... should that item act like "active" or "parent active"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teallarson teallarson

Labels
area/frontend Related to the Airbyte webapp autoteam
Projects
None yet
Milestone
No milestone
4 participants
@edmundito @Upmitt @teallarson @octavia-squidington-iii