Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-mysql: align regular and CDC integration tests and data mappers #13607

Closed
etsybaev opened this issue Jun 8, 2022 · 0 comments · Fixed by #13945
Closed

Source-mysql: align regular and CDC integration tests and data mappers #13607

etsybaev opened this issue Jun 8, 2022 · 0 comments · Fixed by #13945
Assignees

Comments

@etsybaev
Copy link
Contributor

etsybaev commented Jun 8, 2022

Currently, we have 2 different classes for integration datatype tests CdcMySqlSourceDatatypeTest and MySqlSourceDatatypeTest.

  1. Merge them. Make a base class and add the possibility to run it using different configurations (ex. by subclasses where you add config). See SSH (key or login]pass) as an example
  2. update data mappers. Most probably that in some tests for common and CDC sync will have a different expected result. So additional work would be required to align it.
@etsybaev etsybaev self-assigned this Jun 9, 2022
@etsybaev etsybaev self-assigned this Jun 16, 2022
@etsybaev etsybaev linked a pull request Jun 20, 2022 that will close this issue
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant