Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a single SideBar (main menu) component #13766

Closed
teallarson opened this issue Jun 14, 2022 · 1 comment · Fixed by #21227
Closed

Create a single SideBar (main menu) component #13766

teallarson opened this issue Jun 14, 2022 · 1 comment · Fixed by #21227
Assignees
@teallarson
Labels
area/frontend Related to the Airbyte webapp autoteam team/compose

Comments

@teallarson
Copy link
Contributor

There's a lot of repeated code between the cloud package SideBar and the OSS SideBar. It makes updates a more cumbersome and prone to human error.

These can be combined such that cloud is able to use the OSS sidebar and pass in the additional components it needs rendered.
@octavia-squidington-iii octavia-squidington-iii added autoteam area/frontend Related to the Airbyte webapp labels Jun 14, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson teallarson mentioned this issue Jun 28, 2022
Merged
@teallarson teallarson self-assigned this Jan 10, 2023
@teallarson teallarson mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teallarson teallarson

Labels
area/frontend Related to the Airbyte webapp autoteam team/compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟 🧹 Shared SideBar component for Cloud and OSS airbytehq/airbyte
3 participants
@timroes @teallarson @octavia-squidington-iii