Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: Assert that additionalProperties: false is not specified in json schemas #14600

Closed
Tracked by #14097
pedroslopez opened this issue Jul 11, 2022 · 1 comment · Fixed by #14878
Closed
Tracked by #14097

SAT: Assert that additionalProperties: false is not specified in json schemas #14600

pedroslopez opened this issue Jul 11, 2022 · 1 comment · Fixed by #14878
Assignees

Comments

@pedroslopez
Copy link
Contributor

pedroslopez commented Jul 11, 2022

(more context in parent issue #14097)

Following up on #14196, to encode this going forward we should add checks in the SAT to prevent additionalProperties: false.

From the JSON Schema docs, additionalProperties does not necessarily have to be a boolean, so we should just check if it's set and its value is anything other than true.

Acceptance criteria

  • A connector spec schema with additionalProperties set to anything other than true fails SAT
  • A stream schema with additionalProperties set to anything other than true fails SAT
@pedroslopez
Copy link
Contributor Author

grooming notes:

  • this should also check nested definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants