Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Connection Endpoint Cleanup #14733

Closed
alovew opened this issue Jul 14, 2022 · 0 comments · Fixed by #15863
Closed

Update Connection Endpoint Cleanup #14733

alovew opened this issue Jul 14, 2022 · 0 comments · Fixed by #15863

Comments

@alovew
Copy link
Contributor

alovew commented Jul 14, 2022

There are two endpoints to update a connection. WebBackendConnectionHandler#webBackendUpdateConnectionNew and WebBackendConnectionHandler#webBackendUpdateConnection.

We launched Per Stream state using the New endpoint, but we should clean this up by changing the name back to the original and removing the original endpoint.

This will involve:

  • Changing the WebBackendConnectionHandler so there is only one endpoint and updating those tests
  • Updating the OpenApi to remove the UpdateNew endpoint and just use the Update endpoint
  • Remove the WithRefreshedCatalog boolean parameter from WebBackendConnectionUpdate since that parameter is no longer used
  • Update the front end to call the update endpoint instead of updateNew
  • Updating integration tests that are currently calling UpdateNew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants