Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment page calls not firing on Cloud #15849

Closed
timroes opened this issue Aug 22, 2022 · 1 comment · Fixed by #16220
Closed

Segment page calls not firing on Cloud #15849

timroes opened this issue Aug 22, 2022 · 1 comment · Fixed by #16220
Assignees
Labels
area/frontend Related to the Airbyte webapp type/bug Something isn't working

Comments

@timroes
Copy link
Collaborator

timroes commented Aug 22, 2022

Currently the segment calls for page (https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/hooks/services/Analytics/useTrackPageAnalytics.tsx#L15) on Cloud are not firing, since the relevant code is checking for a page URL and only firing if a page name is found, which currently doesn't ever work on Cloud due to workspace ids in the URL.

Talking to Natalie, we should change those human readable page names into a more "id" like format, e.g. Connection.NewPage, instead of human readable ones, when fixing this issue. Also we should make sure, that unknown URLs will still trigger a page call. We could for them just use an ID UnknownPage, since segment already tracks the URL as an additional parameter anyway.

@timroes timroes added type/bug Something isn't working area/frontend Related to the Airbyte webapp growth-eng labels Aug 22, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants