Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use returned streams when updating/saving connection form #16368

Closed
timroes opened this issue Sep 6, 2022 · 3 comments · Fixed by #16748
Closed

Use returned streams when updating/saving connection form #16368

timroes opened this issue Sep 6, 2022 · 3 comments · Fixed by #16748
Assignees
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@timroes
Copy link
Collaborator

timroes commented Sep 6, 2022

Currently we're not updating the sync catalog the connection form holds as data after we send the request. Since #14839 has been fixed the APIs now return the full catalog as part of their response.

We should make sure we're updating our local values to the catalog that has been returned, to prevent any divergence between what we show to the user and the backend actually holds. At the moment we already see some divergence, since the Backend does not accept the sync mode correctly for disabled streams and just set them to something else (#15738).

  • Override the sync catalog in the connection object (if it's not done)
  • Update the replication settings form values to match the connection objects
  • Ensure it has test coverage
  • Must also be tested thoroughly (most likely manually)
  • Ensure that updating connection status, transformation, name does not break the connection configuration
@timroes timroes added area/frontend Related to the Airbyte webapp ui/connection labels Sep 6, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson
Copy link
Contributor

teallarson commented Sep 6, 2022

We should make sure we're updating our local values to the catalog that has been returned.

I think we need to map out when we should be reading from config (what the user has defined and saved to the db) versus stream. I don't think it's all one or the other.

I propose we move this work after #15603 (the service refactor), but I don't think there's harm in doing it in tandem with #15606 (the form refactor) as they shouldn't affect each other.

EDIT: I had assumed this was RE: refreshing/updating the schema, this is in fact about submitting the form and updating the connection object it looks like.

@teallarson
Copy link
Contributor

Re-assigning to KC as this fits within the scope of his latest PR that is addressing submit behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants