Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection form Yup validation schema Typescript improvements #17279

Closed
teallarson opened this issue Sep 27, 2022 · 3 comments
Closed

Connection form Yup validation schema Typescript improvements #17279

teallarson opened this issue Sep 27, 2022 · 3 comments
Assignees
@dizel852
Labels
area/frontend Related to the Airbyte webapp team/compose

Comments

@teallarson
Copy link
Contributor

teallarson commented Sep 27, 2022 •
edited by krishnaglick
Loading

The yup validation schema for the forms related to connection creation/editing need better typing. Currently we have some typecasting going on. Ideally, we should not.

Separated this out of the "main" connection form refactor PRs to keep the deliverables smaller.

Part of the fix will be the schedule type:

    scheduleType: new yup.StringSchema<ConnectionScheduleType>().oneOf([
      ConnectionScheduleType.manual,
      ConnectionScheduleType.basic,
      ConnectionScheduleType.cron,
    ]),

For clarification, this ticket should cover this TODO
@teallarson teallarson added the area/frontend Related to the Airbyte webapp label Sep 27, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson teallarson added team/platform-move area/frontend and removed area/frontend Related to the Airbyte webapp labels Sep 27, 2022
@timroes timroes added area/frontend Related to the Airbyte webapp ui/connection labels Sep 27, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@krishnaglick krishnaglick mentioned this issue Sep 27, 2022
Merged
@edmundito edmundito mentioned this issue Sep 28, 2022
Closed
5 tasks
@edmundito edmundito added the technical-debt issues to fix code smell label Oct 17, 2022
@dizel852 dizel852 assigned dizel852 and unassigned dizel852 Oct 26, 2022
@dizel852
Copy link
Contributor

dizel852 commented Sep 5, 2023

Seems like this one can be fixed in scope of #29585

@dizel852 dizel852 added team/compose and removed technical-debt issues to fix code smell team/platform-move labels Sep 5, 2023
@dizel852 dizel852 self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dizel852 dizel852

Labels
area/frontend Related to the Airbyte webapp team/compose
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@edmundito @timroes @dizel852 @teallarson @octavia-squidington-iii @salima-airbyte