Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads: enable high test strictness level in SAT #19042

Closed
alafanechere opened this issue Nov 7, 2022 · 0 comments · Fixed by #20855
Closed

Source Google Ads: enable high test strictness level in SAT #19042

alafanechere opened this issue Nov 7, 2022 · 0 comments · Fixed by #20855
Assignees

Comments

@alafanechere
Copy link
Contributor

What

A test_strictness_level field was introduced to Source Acceptance Tests (SAT).
Google Ads is a generally_available connector, we want it to have a high test strictness level.

This will help:

  • maximize the SAT coverage on this connector.
  • document its potential weaknesses in term of test coverage.

How

  1. Migrate the existing acceptance-test-config.yml file to the latest configuration format. (See instructions here)
  2. Enable high test strictness level in acceptance-test-config.yml. (See instructions here)
  3. Commit changes on acceptance-test-config.yml and open a PR.
  4. Run SAT with the /test command on the branch.
  5. If tests are failing please fix the failing test or use bypass_reason fields to explain why a specific test can't be run.
@bazarnov bazarnov self-assigned this Jan 5, 2023
@bazarnov bazarnov linked a pull request Jan 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants