Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom connector related jobs should run in a different node pool #19684

Closed
xiaohansong opened this issue Nov 21, 2022 · 1 comment
Closed

Custom connector related jobs should run in a different node pool #19684

xiaohansong opened this issue Nov 21, 2022 · 1 comment
Assignees

Comments

@xiaohansong
Copy link
Contributor

For all activities, we want to create a bit to indicate if that's custom connector related; and if so, in KubeProcessFactory.java we should assign a different node selector to run the jobs.

The custom connector bit could also be useful for metrics tracking purpose.

@pmossman
Copy link
Contributor

Refining notes:

  • Kube process factory controls our node selectors, which is called for every Temporal workflow. We need to pass in a flag that indicates if the source or destination is a custom connector. There are 16 different Temporal job types that will need this flag, so the work here involves updating the 16 different job configs to have a flag for isCustom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants