Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: make property removal in a stream fail backward compatibility testing #20754

Closed
alafanechere opened this issue Dec 21, 2022 · 0 comments · Fixed by #27685
Closed

SAT: make property removal in a stream fail backward compatibility testing #20754

alafanechere opened this issue Dec 21, 2022 · 0 comments · Fixed by #27685

Comments

@alafanechere
Copy link
Contributor

Tell us about the problem you're trying to solve

We considered until today that property removal is not a breaking change as Normalization is not destructive and will not delete the removed column.
But from a record consistency standpoint removing a field leads to record with "fewer" data.

Describe the solution you’d like

  • Detect field removal in SAT discovery backward compatibility test.
  • Make the test fail if a field was removed

An new assertion needs to be added to this function.

@alafanechere alafanechere changed the title SAT: make property removal in a stream fail backward compabitility testing SAT: make property removal in a stream fail backward compatibility testing Dec 21, 2022
@bnchrch bnchrch self-assigned this Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants