Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors should use the StreamName namespace & name fields #2240

Closed
ChristopheDuong opened this issue Mar 1, 2021 · 1 comment
Closed
Labels
type/enhancement New feature or request

Comments

@ChristopheDuong
Copy link
Contributor

ChristopheDuong commented Mar 1, 2021

Tell us about the problem you're trying to solve

Following-up on #2228, sources and destinations should use the new namespace and stream name from the AirbyteStreamName object to determine the source/final destination location of data that is being replicated.

This StreamName would potentially be altered by #2239 in the middle while being in transit from the source to the destination

Describe the solution you’d like

Instead of using AirbyteStream.getName(), destination connectors should rely on AirbyteStream.getStreamName().getNamespace() and AirbyteStream.getStreamName().getName()

(we should remove usage of methods based on AirbyteStream.name

Additional context

This should be the final step to implement #1921 (before implementing the UI part to override final destinations)

@ChristopheDuong ChristopheDuong added the type/enhancement New feature or request label Mar 1, 2021
@ChristopheDuong ChristopheDuong added this to the 2021-03-12 milestone Mar 1, 2021
@ChristopheDuong ChristopheDuong changed the title Destinations should use the StreamName namespace/name fields Connectors should use the StreamName namespace/name fields Mar 1, 2021
@ChristopheDuong ChristopheDuong changed the title Connectors should use the StreamName namespace/name fields Connectors should use the StreamName namespace & name fields Mar 1, 2021
@ChristopheDuong ChristopheDuong removed this from the Core - 2021-03-12 milestone Mar 8, 2021
@davinchia
Copy link
Contributor

Closing as we've chosen a different approach to doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants