Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinations support destination sync modes #2409

Closed
ChristopheDuong opened this issue Mar 11, 2021 · 1 comment · Fixed by #2460
Closed

Destinations support destination sync modes #2409

ChristopheDuong opened this issue Mar 11, 2021 · 1 comment · Fixed by #2460
Assignees
Labels
type/enhancement New feature or request

Comments

@ChristopheDuong
Copy link
Contributor

Tell us about the problem you're trying to solve

As part of #2337, we would like to introduce a new configuration enum for sync modes on the destination side.
Depending on the configuration of the AirbyteCatalog in #2370, destinations should not rely on sync_mode anymore (reserved for sources)

Describe the solution you’d like

Destinations should depend on destination_sync_mode instead to determine if the data in the destination should be overwritten or appended to in the _airbyte_raw tables.

Describe the alternative you’ve considered or used

Destinations can still work in the meantime with the sync_mode from sources as before but then you can't specify full refresh append for example.

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Mar 19, 2021

Since this PR introduces destination connectors that require destination sync modes to be defined, I will wait until the PR for the front-end (#2371) is ready before merging this one (#2460) to master.

Otherwise, newly created sync will be failing since the UI won't be setting/defining destination sync modes yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants