Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source ZohoCRM: API Version is out of date and the optional fields are not defaulted to None #27422

Closed
1 task done
richardlam-quotapath opened this issue Jun 15, 2023 · 2 comments
Assignees
Labels
area/connectors Connector related issues community connectors/source/zoho-crm help-welcome Accepting external contributions team/connectors-python type/bug Something isn't working

Comments

@richardlam-quotapath
Copy link
Contributor

richardlam-quotapath commented Jun 15, 2023

Connector Name

source-zoho-crm

Connector Version

0.1.2

What step the error happened?

None

Revelant information

For a specific customer account we were using, they were not seeing the Deals stream.
After investigating we found that the fields meta data coming back from the Deals stream was missing the "json_type" and "length" property in some of the data. This was causing the deals stream to not be added to the list of streams in the Zoho Streams Factory.
"json_type" is a required type thus this makes sense but "length" is not required thus it shouldn't cause an exit on that.
Upon further inspection we found that even though length is set to Optional, it was not being defaulted to None thus was actually a required field according to this stackoverflow post https://stackoverflow.com/questions/70809438/python-dataclasses-with-optional-attributes.

The reason the "json_type" field was missing is unknown, it would be an issue on Zoho's API. But we found upgrading the api version in the connector from v2 to v4 fixes this problem and all the required fields are present.

Thus this simply requires 2 small fixes:

  1. Updating v2 to v4 for the api version being used in the ZohoCRM connector
  2. Have the optional fields in the FieldMeta class default to None

I will post a PR for this issue shortly.

Relevant log output

No response

Contribute

  • Yes, I want to contribute

PR for the fix found here:
#27423

@pabloescoder
Copy link
Collaborator

I want to work on this issue, can someone please assign it to me?

@justinbchau
Copy link
Collaborator

done ☺️ @pabloescoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community connectors/source/zoho-crm help-welcome Accepting external contributions team/connectors-python type/bug Something isn't working
Projects
No open projects
Status: No status
Status: PR Submitted
8 participants