Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe Source - Expired/Cancelled Subscriptions Not Being Retrieved #4374

Closed
JCWahoo opened this issue Jun 28, 2021 · 1 comment · Fixed by #4669
Closed

Stripe Source - Expired/Cancelled Subscriptions Not Being Retrieved #4374

JCWahoo opened this issue Jun 28, 2021 · 1 comment · Fixed by #4669
Assignees
@annalvova05
Labels
accepting-contributions Feel free to contribute to them area/connectors Connector related issues connectors/source/stripe connectors/sources-api lang/python type/enhancement New feature or request

Comments

@JCWahoo
Copy link

JCWahoo commented Jun 28, 2021

Expected Behavior

Stripe source should retrieve all subscription statuses for the Stripe subscription source. Capturing expiration/cancel/etc is essential to Stripe data integration

Current Behavior

Appears that the connector is currently pulling only active subscriptions, which is the default request.
https://stripe.com/docs/api/subscriptions

Logs

N/A

Steps to Reproduce

  1. Execute Stripe > Target Connection
  2. Review Subscription ABC123 data, active
  3. Customer cancels subscription ABC123
  4. No subscription record is returned on the next execution for subscription ABC123

Severity of the bug for you

High

Airbyte Version

0.26.2-alpha

Connector Version (if applicable)

0.1.12
@JCWahoo JCWahoo added the type/bug Something isn't working label Jun 28, 2021
@sherifnada sherifnada added area/connectors Connector related issues accepting-contributions Feel free to contribute to them type/enhancement New feature or request lang/python and removed type/bug Something isn't working labels Jun 28, 2021
@midavadim
Copy link
Contributor

https://stripe.com/docs/api/subscriptions/list

To list all - add parameters: status=all

@annalvova05 annalvova05 self-assigned this Jul 1, 2021
@bazarnov bazarnov linked a pull request Jul 13, 2021 that will close this issue
🎉 Stripe Source: Fix subscriptions stream to return all kinds of subscriptions (including expired and canceled) #4669
Merged
21 tasks
@sherifnada sherifnada moved this to Done in GL Roadmap Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annalvova05 annalvova05

Labels
accepting-contributions Feel free to contribute to them area/connectors Connector related issues connectors/source/stripe connectors/sources-api lang/python type/enhancement New feature or request
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
5 participants
@midavadim @sherifnada @annalvova05 @JCWahoo @igrankova