Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres Integration Tests are broken #5371

Closed
subodh1810 opened this issue Aug 12, 2021 · 0 comments
Closed

Postgres Integration Tests are broken #5371

subodh1810 opened this issue Aug 12, 2021 · 0 comments
Assignees
@subodh1810
Labels
connectors/source/postgres connectors/sources-database type/bug Something isn't working
Milestone
Core 2021-08-18

Comments

@subodh1810
Copy link
Contributor

There are multiple issues with the postgres connector

  1. After we introduced validation for config objects in the PR 🎉 All java connectors: Added configValidator to check, discover, read and write calls #4699 , the postgres source publish and integration tests have been broken. Which also means the validation changes have not been published for postgres source yet
  2. The CdcPostgresSourceAcceptanceTest was never running in CDC mode, it was running in Standard mode which means it was not really testing what it was supposed to test
  3. The CdcPostgresSourceComprehensiveTest was never running in CDC mode, it was running in Standard mode which means it was not really testing what it was supposed to test. Once I enabled the CDC I realised that there were data types that started breaking, for now I have just ignored the data types, will create a follow up issue to address the data type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subodh1810 subodh1810

Labels
connectors/source/postgres connectors/sources-database type/bug Something isn't working
Projects
None yet
Milestone
Core 2021-08-18
Development

No branches or pull requests
2 participants
@subodh1810 @igrankova