Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Analytics v4: custom_report is not a param in spec.json #5652

Closed
marcosmarxm opened this issue Aug 25, 2021 · 0 comments · Fixed by #5655
Closed

Source Google Analytics v4: custom_report is not a param in spec.json #5652

marcosmarxm opened this issue Aug 25, 2021 · 0 comments · Fixed by #5655
Assignees
@lazebnyi
Labels
area/connectors Connector related issues connectors/source/google-analytics-v4 connectors/sources-api lang/python priority/high High priority type/bug Something isn't working

Comments

@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 25, 2021 •
edited
Loading

airbyte/airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py

Lines 497 to 500 in 35746d1

config["authenticator"] = authenticator
config["ga_streams"] = json.loads(pkgutil.get_data("source_google_analytics_v4", "defaults/default_reports.json")) + json.loads(
config["custom_reports"]
)

Custom Reports are not required and this break the new connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazebnyi lazebnyi

Labels
area/connectors Connector related issues connectors/source/google-analytics-v4 connectors/sources-api lang/python priority/high High priority type/bug Something isn't working
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Source Google Analytics v4: Fix validation of empty custom reports issue airbytehq/airbyte
3 participants
@marcosmarxm @lazebnyi @igrankova