Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Hide connector inputs labelled as hidden #5668

Closed
sherifnada opened this issue Aug 26, 2021 · 4 comments
Closed

UI: Hide connector inputs labelled as hidden #5668

sherifnada opened this issue Aug 26, 2021 · 4 comments
Assignees
Labels
priority/low Low priority type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

#5465 is a good example of us needing to define some parameters that are used only for development or testing but which are not visible to the user. It would be nice to be able to define those in the spec for very clear visibility, but this is not a

Describe the solution you’d like

I would like a connector to be able to label its spec inputs as hidden:true and have the UI hide them e.g:

{
  connectionSpecification: {
     properties: {
       p1: {
         type: string
         hidden: true
       }
     }
  }
}
@sherifnada sherifnada added type/enhancement New feature or request area/frontend labels Aug 26, 2021
@sherifnada sherifnada changed the title Allow a connector to label an input in its spec as hidden or development UI: Hide connector inputs labelled as hidden Aug 26, 2021
@jrhizor jrhizor added the priority/low Low priority label Aug 30, 2021
@jamakase
Copy link
Contributor

jamakase commented Sep 6, 2021

@sherifnada I understand why you may need it, however, I believe that it is actually not what should be handled on frontend side. Hiding the field actually means, that you want to totally remove this field ( don't validate it, don't display it ) and all of its descendants in case of the object. If it's going to be used for testing purposes only ( in dev only? ) it is not a problem to change spec and update connector.

Isn't it better to traverse the schema and return the proper schema to be displayed from the server? In this case, any other client that will use our API won't need to adjust the logic and know, that field with hidden is actually skipped field even if it's added into required section

@jamakase jamakase self-assigned this Oct 6, 2021
@jamakase
Copy link
Contributor

@jrhizor Actually this is already supported with airbyte_hidden tag that was introduced to support proper oauth behaviour.

@sherifnada
Copy link
Contributor Author

@jamakase is this then considered "official"/defined behavior? Should we add it to the spec reference?

@jamakase
Copy link
Contributor

Not sure what you mean as official defined behaviour. We just do not display fields with airbyte_hidden :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Low priority type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants