Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Webserver: Expose an endpoint to which a user should be redirected after granting Oauth consent #5770

Closed
Tracked by #5769
sherifnada opened this issue Aug 31, 2021 · 0 comments · Fixed by #6385
Closed
Tracked by #5769
Assignees
Labels

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Aug 31, 2021

Once a user grants consent and is redirected back to airbyte, they should be redirected to an endpoint which will do the following:

  1. call complete_auth_request on the backend server, providing the following inputs:
    1. connector definition ID
    2. current workspace ID
    3. any query params found in the redirect URL
  2. complete_auth_request will return an object containing some properties related to oauth e.g: {refresh_token: XYZ, access_token: XYZ, ...}. Using this response, the UI should pre-fill any fields with the same name. For example, if the spec has only {refresh_token: {type: string}} then the UI should pre-fill that field with the value returned from the API.
  3. Display the spec as normal and allow the user to fill it out like normal

The below diagram illustrates how this would work. See the portion after "Redirect user to airbyte with auth code".

Screen Shot 2021-08-30 at 5 27 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants