Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Okta: support oauth #6275

Closed
sherifnada opened this issue Sep 19, 2021 · 1 comment
Closed

Source Okta: support oauth #6275

sherifnada opened this issue Sep 19, 2021 · 1 comment

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret
  2. Oauth properties are annotated properly. See this PR for an example
@sherifnada sherifnada added area/oauth area/connectors Connector related issues labels Sep 19, 2021
@sherifnada sherifnada added this to the Connectors 2021-10-29 milestone Oct 14, 2021
@gaart gaart self-assigned this Oct 18, 2021
@gaart gaart linked a pull request Oct 21, 2021 that will close this issue
38 tasks
@gaart
Copy link
Contributor

gaart commented Oct 22, 2021

Okta doesn’t need oauth I believe because it can just support API key.

by @sherifnada

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants