Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source TikTok Marketing: support oauth #7098

Closed
Tracked by #7000
cheyura opened this issue Oct 17, 2021 · 0 comments · Fixed by #7636
Closed
Tracked by #7000

Source TikTok Marketing: support oauth #7098

cheyura opened this issue Oct 17, 2021 · 0 comments · Fixed by #7636
Assignees
Labels
area/connectors Connector related issues area/oauth type/enhancement New feature or request

Comments

@cheyura
Copy link

cheyura commented Oct 17, 2021

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance criteria

The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
Oauth properties are annotated properly. See this PR for an example

@cheyura cheyura added type/enhancement New feature or request area/oauth labels Oct 17, 2021
@annalvova05 annalvova05 self-assigned this Oct 27, 2021
@annalvova05 annalvova05 linked a pull request Nov 4, 2021 that will close this issue
15 tasks
@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
@annalvova05 annalvova05 changed the title Source TikTok Ads: support oauth Source TikTok Marketing: support oauth Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/oauth type/enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants