Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building the platform, add the specs for each connector in the seed #7142

Closed
cgardens opened this issue Oct 18, 2021 · 0 comments · Fixed by #7501
Closed

When building the platform, add the specs for each connector in the seed #7142

cgardens opened this issue Oct 18, 2021 · 0 comments · Fixed by #7501
Assignees
Labels
type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

Tell us about the problem you're trying to solve

We are trying to add the spec to the source/destination definitions table so that we do not need to run the spec method on a connector every time we need a spec. See the epic for more info: #6174.

Since we want to get to the place where spec is a required column in the connector definitions table, we need to figure out a way at build time to guarantee that all of the specs are loaded in the seed.

Describe the solution you’d like

For any connector that Airbyte publishes, we already push its spec into this GCS bucket. We could continue to leverage it in the build. For each connector in the seed, fetch its spec from the the bucket (if it is not already in the seed).

If the spec is not in the cache, we can probably just fail. The alternative is that we could attempt to run the spec method for that container as part of the build. Since we have full control over the bucket spec, it makes sense to use it then adding another, potentially brittle code path.

As part of this project, we will need to store the spec of each connector in the source code. We want to keep the connector definitions human readable, so the specs should be stored separately in the resources directory.

What you'll learn

  • How we seed connectors into the Airbyte OSS platform
  • Gradle!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants