Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Notion: support oauth #8223

Closed
Tracked by #7000 ...
igrankova opened this issue Nov 24, 2021 · 1 comment · Fixed by #14706
Closed
Tracked by #7000 ...

Source Notion: support oauth #8223

igrankova opened this issue Nov 24, 2021 · 1 comment · Fixed by #14706
Assignees

Comments

@igrankova
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance criteria

The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
Oauth properties are annotated properly. See this PR for an example

[EPIC] Implement OAuth Flow for Cloud connectors #7000

@igrankova igrankova added type/enhancement New feature or request area/connectors Connector related issues requires-oauth connector which requires oauth labels Nov 24, 2021
@igrankova
Copy link
Contributor Author

igrankova commented Nov 24, 2021

The App is Public: https://www.notion.so/my-integrations/public/2d1ca561f9c54a778ce818a583a7499e
The authorization flow is passed successful
LastPass creds name: Notion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: In review (internal)
Development

Successfully merging a pull request may close this issue.

3 participants