From eb3faefe4e79df61303634bc7101d474de82d17e Mon Sep 17 00:00:00 2001 From: Leo Mansini Date: Fri, 6 May 2022 11:45:23 -0300 Subject: [PATCH 1/4] (feat) include bid fields in fb mkting adsets --- .../source_facebook_marketing/schemas/ad_sets.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json index bb203911eb61..ed4a0abbeb74 100644 --- a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json +++ b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json @@ -88,6 +88,15 @@ } } }, + "bid_strategy" : { + "type": ["null", "string"] + }, + "bid_amount": { + "type": ["null", "number"] + }, + "bid_constraints": { + "type": ["null", "object"] + }, "adlabels": { "type": ["null", "array"], "items": { From 7f7f5eabca893aeca239a0ce20517ab362c9bfaf Mon Sep 17 00:00:00 2001 From: Leo Mansini Date: Fri, 6 May 2022 12:00:59 -0300 Subject: [PATCH 2/4] bump versions --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- airbyte-config/init/src/main/resources/seed/source_specs.yaml | 2 +- .../connectors/source-facebook-marketing/Dockerfile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index 0904622573af..0453ec5718f7 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -210,7 +210,7 @@ - name: Facebook Marketing sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c dockerRepository: airbyte/source-facebook-marketing - dockerImageTag: 0.2.44 + dockerImageTag: 0.2.45 documentationUrl: https://docs.airbyte.io/integrations/sources/facebook-marketing icon: facebook.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 0db0866bfa11..ae9f246ca2fa 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -1747,7 +1747,7 @@ supportsNormalization: false supportsDBT: false supported_destination_sync_modes: [] -- dockerImage: "airbyte/source-facebook-marketing:0.2.44" +- dockerImage: "airbyte/source-facebook-marketing:0.2.45" spec: documentationUrl: "https://docs.airbyte.io/integrations/sources/facebook-marketing" changelogUrl: "https://docs.airbyte.io/integrations/sources/facebook-marketing" diff --git a/airbyte-integrations/connectors/source-facebook-marketing/Dockerfile b/airbyte-integrations/connectors/source-facebook-marketing/Dockerfile index 57484775451d..dbf4bac16a10 100644 --- a/airbyte-integrations/connectors/source-facebook-marketing/Dockerfile +++ b/airbyte-integrations/connectors/source-facebook-marketing/Dockerfile @@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.2.44 +LABEL io.airbyte.version=0.2.45 LABEL io.airbyte.name=airbyte/source-facebook-marketing From 4b0d57a7ebbbf7cc62e3877b2813dae8d2992b3e Mon Sep 17 00:00:00 2001 From: santiago Date: Wed, 8 Jun 2022 18:11:03 -0300 Subject: [PATCH 3/4] docs: updated changelog in facebook-marketing.md --- docs/integrations/sources/facebook-marketing.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/integrations/sources/facebook-marketing.md b/docs/integrations/sources/facebook-marketing.md index ddcadaf1627d..400903e43497 100644 --- a/docs/integrations/sources/facebook-marketing.md +++ b/docs/integrations/sources/facebook-marketing.md @@ -108,6 +108,7 @@ For more information, see the [Facebook Insights API documentation.](https://dev | Version | Date | Pull Request | Subject | |:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| 0.2.45 | 2022-06-08 | [13623](https://github.com/airbytehq/airbyte/pull/13623) | Added fields `bid_amount` `bid_strategy` `bid_constraints` to `ads_set` stream. | | 0.2.44 | 2022-04-14 | [11751](https://github.com/airbytehq/airbyte/pull/11751) | Update API to a directly initialise an AdAccount with the given ID | | 0.2.43 | 2022-04-13 | [11801](https://github.com/airbytehq/airbyte/pull/11801) | Fix `user_tos_accepted` schema to be an object | 0.2.42 | 2022-04-06 | [11761](https://github.com/airbytehq/airbyte/pull/11761) | Upgrade Facebook Python SDK to version 13| From 377c3170b87e0bbbd525a32048353d2c0817fe7a Mon Sep 17 00:00:00 2001 From: santiago Date: Fri, 10 Jun 2022 14:40:39 -0300 Subject: [PATCH 4/4] refactor: added schema of the bid_constraints object --- .../source_facebook_marketing/schemas/ad_sets.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json index ed4a0abbeb74..87dd56060b0d 100644 --- a/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json +++ b/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json @@ -95,7 +95,12 @@ "type": ["null", "number"] }, "bid_constraints": { - "type": ["null", "object"] + "type": ["null", "object"], + "properties": { + "roas_average_floor": { + "type": ["null", "integer"] + } + } }, "adlabels": { "type": ["null", "array"],