Source Hubspot: best practices #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keu
requested review from
sherifnada and
yevhenii-ldv
and removed request for
michel-tricot and
cgardens
keu
force-pushed
the
keu/source-hubspot-best-practices
branch
from
92a8bd6 to
ce9a325
Compare
|
/test connector=source-hubspot
|
Closed
4 tasks
|
/test connector=source-hubspot
|
sherifnada
approved these changes
Mar 19, 2021
| return {"api_key": "wrong_key"} | ||
|
|
||
|
|
||
| def test__heal_check_with_wrong_token(wrong_credentials): |
There was a problem hiding this comment.
Suggested change
| def test__heal_check_with_wrong_token(wrong_credentials): | |
| def test__healh_check_with_wrong_token(wrong_credentials): |
| from source_hubspot.errors import HubspotInvalidAuth | ||
|
|
||
|
|
||
| @pytest.fixture(name="wrong_credentials") |
There was a problem hiding this comment.
some of these tests should be integration tests since they are making API calls (or they should be mocked)
|
/test connector=source-hubspot
|
keu
added a commit
that referenced
this pull request
Mar 20, 2021
* #2150 Issue: created native connector with schema folder populated * #2150 Issue: make format code * first version * fix few issues * fix issues * fix read issue * format * docs * docker tags * extend configured catalog for testing * fix source definitions * format * fix call rate issue, add backoff for retry after * add general backoff * write secrets for new connector * drop singer connector registration * refactor streams, resolve properties in schemas at runtime * replace deprecated endpoint for company contacts * replace deprecated pipeline endpoint * update comments * update docs * fix typo * fix stream contact lists * fix pagination and forms result fetching * fix health_check * format and update catalog * revert changes * drop singer based hubspot * fix company contacts substream * move deals to separate test * fix deals tests * remove dynamic fields from records * move deals to catalog again * extend CRMObjectStream with associations * format * update schemas with updated field, change engagement layout * fix Campaign stream * remove custom tests * remove dependency * remove oauth * Source Hubspot: add incremental streams (#2425) * add incremental * add incremental * polishing * update docs * fix docstring * clean up * fix incremental bookmark access * fix incremental tests * clean up * add custom test for incremental, improve logging * format * Update airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Source Hubspot: best practices (#2537) * fix error reporting and add unit tests * fix test and refactor cursor fields * format Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com> * restored configured_catalog.json Co-authored-by: ykurochkin <y.kurochkin@zazmic.com> Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #2221
How
Describe the solution
Pre-merge Checklist
Recommended reading order
test.javacomponent.ts