Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source-connector for Google Analytics v4 #5290

Merged
merged 17 commits into from
Aug 25, 2021
Merged

🎉 New Source-connector for Google Analytics v4 #5290

merged 17 commits into from
Aug 25, 2021

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Aug 9, 2021 •
edited
Loading

What

Resolving the issue:
#4463 - New Source-connector for Google Analytics v4

How

Using CDK and custom methods implemented the connector logic for Google Analytics v4 as a source for Airbyte.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 9, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 10, 2021
@lazebnyi lazebnyi requested review from bazarnov and midavadim August 10, 2021 10:26
@lazebnyi lazebnyi linked an issue Aug 10, 2021 that may be closed by this pull request
New Source: Google Analytics v4 #4463
Closed
bazarnov
bazarnov requested changes Aug 11, 2021
View reviewed changes
...c/main/resources/config/STANDARD_SOURCE_DEFINITION/eff3616a-f9c3-11eb-9a03-0242ac130003.json Outdated Show resolved Hide resolved
airbyte-config/init/src/main/resources/seed/source_definitions.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/integration_tests/sample_config.json Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
bazarnov
bazarnov approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@bazarnov bazarnov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add some tests for the custom method used inside the code.

@lazebnyi lazebnyi force-pushed the lazebnyi/4463-google-analytics-v4 branch from 6dfea68 to 9b0cb21 Compare August 11, 2021 10:30
@lazebnyi lazebnyi linked an issue Aug 11, 2021 that may be closed by this pull request
Google Analytics source check function does not work correctly #5273
Closed
midavadim
midavadim suggested changes Aug 12, 2021
View reviewed changes
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
@lazebnyi lazebnyi requested a review from midavadim August 12, 2021 14:58
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 13, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1127963804
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1127963804

@jrhizor jrhizor temporarily deployed to more-secrets August 13, 2021 14:22 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 13, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1127996066
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1127996066

@jrhizor jrhizor temporarily deployed to more-secrets August 13, 2021 14:32 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 13, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1128037597
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1128037597

@jrhizor jrhizor temporarily deployed to more-secrets August 13, 2021 14:47 Inactive
@lazebnyi lazebnyi requested a review from midavadim August 16, 2021 15:29
@lazebnyi lazebnyi requested a review from midavadim August 17, 2021 13:03
@lazebnyi lazebnyi requested a review from midavadim August 19, 2021 11:18
@lazebnyi lazebnyi requested a review from midavadim August 19, 2021 12:42
@lazebnyi lazebnyi requested a review from Phlair August 19, 2021 12:50
@lazebnyi lazebnyi marked this pull request as ready for review August 19, 2021 12:50
Phlair
Phlair reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach here! User docs are great and nice unit tests!

What will happen (jn terms of UX) in the case where user adds custom streams that don't allow incremental. Will it force all streams to be full refresh? Some other behaviour?

Some small points in comments

airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Outdated Show resolved Hide resolved
...egrations/connectors/source-google-analytics-v4/unit_tests/metrics_dimensions_type_list.json Outdated Show resolved Hide resolved
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 25, 2021 •
edited
Loading

What will happen (jn terms of UX) in the case where user adds custom streams that don't allow incremental. Will it force all streams to be full refresh? Some other behaviour?

Custom streams didn't affect on any other streams.

@lazebnyi lazebnyi requested a review from Phlair August 25, 2021 13:38
Phlair
Phlair approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand, lgtm!

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 25, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1166920281
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1166920281

@jrhizor jrhizor temporarily deployed to more-secrets August 25, 2021 14:38 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 25, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1166954343
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1166954343

@jrhizor jrhizor temporarily deployed to more-secrets August 25, 2021 14:48 Inactive
@lazebnyi lazebnyi merged commit 2ee462a into master Aug 25, 2021
@lazebnyi lazebnyi deleted the lazebnyi/4463-google-analytics-v4 branch August 25, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phlair Phlair Phlair approved these changes

@bazarnov bazarnov bazarnov approved these changes

@midavadim midavadim midavadim approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Analytics source check function does not work correctly New Source: Google Analytics v4
5 participants
@lazebnyi @midavadim @bazarnov @Phlair @jrhizor