Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Google Ads improvement: Support user-specified queries #5302

Merged
merged 39 commits into from
Sep 10, 2021
Merged

🎉 Google Ads improvement: Support user-specified queries #5302

merged 39 commits into from
Sep 10, 2021

Commits on Aug 5, 2021

  1. save the state

    @vovavovavovavova
    vovavovavovavova committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    7ba083b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. save big-big-big draft with dirty pre-upgrade

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    0b57c89 View commit details
    Browse the repository at this point in the history

  2. save draft

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    7ba9a5c View commit details
    Browse the repository at this point in the history

  3. rm prints and schemas on fly

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    0b343da View commit details
    Browse the repository at this point in the history

  4. fix

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    cbb274a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into valdemar/#5165_cust… 

    …om_query_stream
    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    7c4a212 View commit details
    Browse the repository at this point in the history

  6. update spec

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    a4ddc06 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    5a27b95 View commit details
    Browse the repository at this point in the history

  8. upgrade configured_catalog for tests

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    00b9fa1 View commit details
    Browse the repository at this point in the history

  9. rm previously used (now not) parameter

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6a2d3d7 View commit details
    Browse the repository at this point in the history

  10. upd suggestion

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    7e4c397 View commit details
    Browse the repository at this point in the history

  11. format && cleanup imports

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    2c9efa3 View commit details
    Browse the repository at this point in the history

  12. remove outdated

    @vovavovavovavova
    vovavovavovavova committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    b297a6a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. dedup code

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    80c6e2d View commit details
    Browse the repository at this point in the history

  2. dedup 2 lines

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    99c8e02 View commit details
    Browse the repository at this point in the history

  3. clean

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    4e17d84 View commit details
    Browse the repository at this point in the history

  4. Update airbyte-integrations/connectors/source-google-ads/source_googl… 

    …e_ads/spec.json

Co-authored-by: Eugene Kulak <widowmakerreborn@gmail.com>
    @vovavovavovavova @keu
    vovavovavovavova and keu authored Aug 11, 2021
    Configuration menu
    Copy the full SHA
    c7256c6 View commit details
    Browse the repository at this point in the history

  5. rm discovery modification; apply get_json_schema instead.

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    c31c3fd View commit details
    Browse the repository at this point in the history

  6. upgrade spec; query with field separator

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    78adddf View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into valdemar/#5165_cust… 

    …om_query_stream
    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    e17a320 View commit details
    Browse the repository at this point in the history

  8. move def process_query inside get_fields_from_schema

    @vovavovavovavova
    vovavovavovavova committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    14e80e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. re-write to incremental with 2 moments

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    f43c29f View commit details
    Browse the repository at this point in the history

  2. add pattern for basic query validation

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    5775511 View commit details
    Browse the repository at this point in the history

  3. add other resources than campaign

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    a7abb83 View commit details
    Browse the repository at this point in the history

  4. add as anytype?

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    dd737dd View commit details
    Browse the repository at this point in the history

  5. dedup code

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ad8b2c0 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into valdemar/#5165_cust… 

    …om_query_stream
    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    baae471 View commit details
    Browse the repository at this point in the history

  7. cleanup+ typo fix

    @vovavovavovavova
    vovavovavovavova committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    1ce8bf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. merge; add a lot of resources; fix pattern(allow other resources); fi… 

    …x spec
    @vovavovavovavova
    vovavovavovavova committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    a4685dc View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. disable incremental in custom queries (requested)

    @vovavovavovavova
    vovavovavovavova committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    bbd678f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Update airbyte-integrations/connectors/source-google-ads/source_googl… 

    …e_ads/spec.json

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
    @vovavovavovavova @sherifnada
    vovavovavovavova and sherifnada authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    7fa232f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. add unit tests

    @vovavovavovavova
    vovavovavovavova committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    a7b8916 View commit details
    Browse the repository at this point in the history

  2. rm double set

    @vovavovavovavova
    vovavovavovavova committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    0ba4690 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into valdemar/#5165_cust… 

    …om_query_stream
    @vovavovavovavova
    vovavovavovavova committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9aaab72 View commit details
    Browse the repository at this point in the history

  4. set prev version since https://github.com/googleads/google-ads-python… 

    …/releases was released 2 hours ago and now config is incompatible (missing param)
    @vovavovavovavova
    vovavovavovavova committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2260ca2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Compose json schema based on metadata request

    Dmytro Rezchykov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    3ee960b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Add incremental stream support

    Dmytro Rezchykov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c5d55de View commit details
    Browse the repository at this point in the history

  2. Add gradle link on CI comment when build failed.

    Dmytro Rezchykov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    612ffc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Fix review comments

    Dmytro Rezchykov committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    22be66e View commit details
    Browse the repository at this point in the history