Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source BigQuery: Fix NPE when dataset_id isn't provided #6051

Merged
merged 4 commits into from
Sep 23, 2021
Merged

Source BigQuery: Fix NPE when dataset_id isn't provided #6051

merged 4 commits into from
Sep 23, 2021

Conversation

69mb
Copy link
Contributor

@69mb 69mb commented Sep 14, 2021

What

Fixes #5326

How

dataset_id is an optional config parameter so made change to store
and handle it as empty string.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 14, 2021
marcosmarxm
marcosmarxm requested changes Sep 15, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @69mb small comment on formatting files. I'll review later today!

airbyte-integrations/connectors/source-bigquery/src/test/resources/test_config.json Outdated Show resolved Hide resolved
@marcosmarxm marcosmarxm self-assigned this Sep 15, 2021
@prasrvenkat prasrvenkat mentioned this pull request Sep 21, 2021
Closed
@marcosmarxm
Copy link
Member

Hi @69mb can you solve the conflict and apply ./gradlew format? I'll run tests and check your code later today.

@69mb
Source BigQuery: Fix for NPE when dataset_id isn't provided
c036092 
* changes for an empty `dataset_id` in the configuration
* added changelog
* bumped version
@69mb
Source Bigquery: Version should be 0.1.2 🤦‍♂️
2ce5aff
@69mb
Source BigQuery: Fixed formatting
1b83934 
* Fixes from `./gradlew format` run
@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/documentation Improvements or additions to documentation area/frontend area/worker Related to worker CDK Connector Development Kit kubernetes normalization labels Sep 23, 2021
@github-actions github-actions bot removed area/frontend area/documentation Improvements or additions to documentation area/platform issues related to the platform area/api Related to the api area/worker Related to worker CDK Connector Development Kit normalization kubernetes labels Sep 23, 2021
marcosmarxm
marcosmarxm approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @69mb

@marcosmarxm marcosmarxm merged commit 9c5572b into airbytehq:master Sep 23, 2021
@69mb 69mb deleted the bmuita/source-bigquery branch September 23, 2021 06:39
@jrhizor jrhizor mentioned this pull request Sep 25, 2021
Merged
@prasrvenkat prasrvenkat mentioned this pull request Sep 29, 2021
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues connectors/source/bigquery connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery source: "Could not connect with provided configuration. Error: null"
3 participants
@69mb @marcosmarxm @igrankova