Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FetchingSourceConnectorError.tsx #6053

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

isalikov
Copy link
Contributor

@isalikov isalikov commented Sep 14, 2021

What

Added FetchingSourceConnectorError.tsx view whet request to load source connector fails.
It helps to add screenshots if it affects the frontend.

image

Copy link
Contributor

@jamakase jamakase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need same logic for destination :)

@isalikov isalikov temporarily deployed to more-secrets September 20, 2021 12:29 Inactive
@isalikov isalikov temporarily deployed to more-secrets September 20, 2021 16:23 Inactive
@isalikov isalikov temporarily deployed to more-secrets September 20, 2021 16:52 Inactive
@jamakase jamakase merged commit 6d9ba02 into master Sep 22, 2021
@jamakase jamakase deleted the 3809/show-source_definition_specifications/get-error branch September 22, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add meaningful error in UI when source_definition_specifications/get fails and user can't specify schema.
2 participants