Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Iterable: Fixed normalization issue #6242

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

yaroslav-dudar
Copy link
Contributor

What

Fixed schema in streams: campaigns, lists, templates, metadata #5867

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 18, 2021
@yaroslav-dudar
Copy link
Contributor Author

maybe we need to wait for this PR #5915 . There are an acceptance test added , etc

@yaroslav-dudar yaroslav-dudar changed the title Yaroslav dudar/5867 🐛 Source Iterable: Fixed normalization issue Sep 18, 2021
@yaroslav-dudar yaroslav-dudar linked an issue Sep 18, 2021 that may be closed by this pull request
Copy link
Contributor

@midavadim midavadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that SAT are passed

@yaroslav-dudar yaroslav-dudar marked this pull request as ready for review September 20, 2021 12:09
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 20, 2021

@davinchia we have parallel PR here. I'm not sure which one has higher priority #6242 (comment)

@marcosmarxm
Copy link
Member

@davinchia we have parallel PR here. I'm not sure which one has higher priority #6242 (comment)

can we merge this first? there is a user having problem because of this issue. check slack convo

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosmarxm is integer the right datatype to have?

@yaroslav-dudar please make sure the tests passes before merging in.

@yaroslav-dudar
Copy link
Contributor Author

@davinchia there no acceptance tests for this connector right now. guys added tests in this PR #5915, but I don't know if it's close to finalizing

@davinchia
Copy link
Contributor

@yaroslav-dudar got it. Let me check with Marcos if this is right.

@marcosmarxm
Copy link
Member

@marcosmarxm is integer the right datatype to have?

yes, https://api.iterable.com/api/docs
image

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 24, 2021

/publish connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1270238634
❌ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1270238634

@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 14:39 Inactive
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 24, 2021

/publish connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1270264975
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/1270264975

@yaroslav-dudar yaroslav-dudar temporarily deployed to more-secrets September 24, 2021 14:45 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 14:47 Inactive
@yaroslav-dudar yaroslav-dudar temporarily deployed to more-secrets September 24, 2021 15:07 Inactive
@yaroslav-dudar yaroslav-dudar merged commit ff479de into master Sep 24, 2021
@yaroslav-dudar yaroslav-dudar deleted the yaroslav-dudar/5867 branch September 24, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector Iterable failing in normalization process
6 participants