Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG-4307: Fix incorrect handling of LONG RAW data type #7125

Merged
merged 5 commits into from
Oct 21, 2021
Merged

🐛 BUG-4307: Fix incorrect handling of LONG RAW data type #7125

merged 5 commits into from
Oct 21, 2021

Conversation

alexandertsukanov
Copy link
Contributor

@alexandertsukanov alexandertsukanov commented Oct 18, 2021 •
edited
Loading

What

Fixed insert of Decimal type during Oracle Source integration test.

How

  • Added property useFetchSizeWithLongColumn to Oracle JDBC Driver to resolve SQLException exception in case of LONG RAW.

  • Removed TO_BINARY_DOUBLE Aggregate Oracle's DB function, replaced with native DECIMAL datatype value. To fix the OracleSourceDatatypeTest.java test.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 18, 2021
@alexandertsukanov
Copy link
Contributor Author

alexandertsukanov commented Oct 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1354973556
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1354973556
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 14:03 Inactive
@alexandertsukanov alexandertsukanov linked an issue Oct 18, 2021 that may be closed by this pull request
Source Oracle: incorrect handling of LONG RAW data type #4307
Closed
@alexandertsukanov
BUG-4307: Added property useFetchSizeWithLongColumn to Oracle JDBC Dr…
0dcab3f 
…iver to resolve SQLException exception in case of LONG RAW.
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets October 20, 2021 07:13 Inactive
@alexandertsukanov
Merge branch 'master' into otsukanov/4307-incorrect_handling_of_LONG_…
7c0ada5 
…RAW_data_type

# Conflicts:
#	airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
@alexandertsukanov
Copy link
Contributor Author

alexandertsukanov commented Oct 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1362455076
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1362455076
No Python unittests run

@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets October 20, 2021 07:17 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 20, 2021 07:19 Inactive
@alexandertsukanov alexandertsukanov marked this pull request as ready for review October 20, 2021 09:05
davinchia
davinchia reviewed Oct 21, 2021
View reviewed changes
...nnectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
@@ -55,6 +55,15 @@ public static Source sshWrappedSource() {
public JsonNode toDatabaseConfig(final JsonNode config) {
final List<String> additionalParameters = new ArrayList<>();

/*
The property useFetchSizeWithLongColumn required to select LONG or LONG RAW columns.
Oracle recommends avoiding LONG and LONG RAW columns. Use LOB instead. They are included in Oracle only for legacy reasons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice comments.

davinchia
davinchia reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Before I approve, can you also please go through the check list and update the required documentation? Thanks.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 21, 2021
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets October 21, 2021 10:36 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets October 21, 2021 11:51 Inactive
@alexandertsukanov
Copy link
Contributor Author

alexandertsukanov commented Oct 21, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1368555572
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1368555572

@jrhizor jrhizor temporarily deployed to more-secrets October 21, 2021 15:29 Inactive
@alexandertsukanov alexandertsukanov merged commit 561fabe into master Oct 21, 2021
@alexandertsukanov alexandertsukanov deleted the otsukanov/4307-incorrect_handling_of_LONG_RAW_data_type branch October 21, 2021 16:01
@jrhizor jrhizor mentioned this pull request Oct 21, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@alexandertsukanov @schlattk
🐛 BUG-4307: Fix incorrect handling of LONG RAW data type (airbytehq#7125
cab306a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@davinchia davinchia davinchia approved these changes

@irynakruk irynakruk irynakruk approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Oracle: incorrect handling of LONG RAW data type
6 participants
@alexandertsukanov @CLAassistant @irynakruk @davinchia @alexandr-shegeda @jrhizor