fix more doc links #7146
Merged
fix more doc links #7146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
davinchia
approved these changes
Oct 19, 2021
sherifnada
approved these changes
Oct 19, 2021
| | US Production | [https://rest.zuora.com](https://rest.zuora.com) | | ||
| | US Cloud Production | [https://rest.na.zuora.com](https://rest.na.zuora.com) | | ||
| | EU Production | [https://rest.eu.zuora.com](https://rest.eu.zuora.com) | | ||
| | US Production | rest.zuora.com | |
There was a problem hiding this comment.
so does this effectively make the checker ignore them? if so, I would rather we keep the hyperlink. If this is not ignoring them then let's keep it this way.
There was a problem hiding this comment.
checked in slack with @sherifnada, these are just api endpoint domains so we're fine dropping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc check is failing on master for a variety of reasons. I think this catches them all.
@sherifnada I'm changing the Zuora endpoints to not be links since none of them are directly resolvable. Let me know if you want me to revert to ignoring them instead of just listing the domains.