Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Connector Facebook-Marketing: update insights streams with custom entries for fields, breakdowns and action_breakdowns #7158

Merged
merged 15 commits into from
Oct 19, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

Clones #4864, created for publish new version.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 19, 2021

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358852195
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358852195
🐛 https://gradle.com/s/jp7ih5vj7vfcs

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 19, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 19, 2021 11:13 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 11:15 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 19, 2021

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358949253
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358949253
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                    Stmts   Miss  Cover
	 -----------------------------------------------------------
	 source_facebook_marketing/__init__.py       2      0   100%
	 source_facebook_marketing/api.py           75     17    77%
	 source_facebook_marketing/common.py        36     11    69%
	 source_facebook_marketing/source.py       112     65    42%
	 source_facebook_marketing/streams.py      253     95    62%
	 -----------------------------------------------------------
	 TOTAL                                     478    188    61%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                    Stmts   Miss  Cover
	 -----------------------------------------------------------
	 source_facebook_marketing/__init__.py       2      0   100%
	 source_facebook_marketing/api.py           75     18    76%
	 source_facebook_marketing/common.py        36      1    97%
	 source_facebook_marketing/source.py       112     72    36%
	 source_facebook_marketing/streams.py      253     95    62%
	 -----------------------------------------------------------
	 TOTAL                                     478    186    61%

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 19, 2021 11:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 11:43 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 19, 2021

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358978943
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1358978943

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 19, 2021 11:51 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 11:53 Inactive
@yevhenii-ldv yevhenii-ldv merged commit b18acd6 into master Oct 19, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/publish-pr-4864 branch October 19, 2021 12:08
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…ntries for fields, breakdowns and action_breakdowns (airbytehq#7158)

* Connector Facebook-Marketing: update streams with custom streams

* update: remove custom streams, add new custom insights from config

* update: add new model for InsightConfig, remove old imports

* fix: format to source file and streams file

* update Changelog

* update: add to check a validation to insights entries, update documentation and fix to resolve  in spec schema

* fix: fix import logger from entrypoint, change to python logger

* fix: change error message from check custom insights entries, fix logger import

Co-authored-by: vladimir <vladimir.remar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants