Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform option to fix build temporarily #7184

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Oct 19, 2021

Summary

Logs

Sample github action run:
https://github.com/airbytehq/airbyte/runs/3943186008

Logs:

The Compose file './docker-compose.build.yaml' is invalid because:

Unsupported config option for services.db: 'platform'
> Task :composeBuild FAILED
Unsupported config option for services.init: 'platform'
Unsupported config option for services.migration: 'platform'
Unsupported config option for services.scheduler: 'platform'
Unsupported config option for services.server: 'platform'
Unsupported config option for services.webapp: 'platform'
Unsupported config option for services.worker: 'platform'

It's interesting that there is no complaint for services.db, which also specifies the platform option.

@tuliren tuliren requested a review from jrhizor October 19, 2021 19:07
@tuliren tuliren temporarily deployed to more-secrets October 19, 2021 19:07 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Oct 19, 2021

@davinchia, which docker-compose version do we use for the github runner? Can we upgrade it to 1.27.0-rc1 which is supposed to support the platform option?

@marcosmarxm
Copy link
Member

@davinchia, which docker-compose version do we use for the github runner? Can we upgrade it to 1.27.0-rc1 which is supposed to support the platform option?

To use Airbyte now we need to use docker-compose v 1.27+? Just checking if we need to update some docs.

@tuliren
Copy link
Contributor Author

tuliren commented Oct 19, 2021

To use Airbyte now we need to use docker-compose v 1.27+? Just checking if we need to update some docs.

It's possible. This version may be required to support M1 Mac. I have not confirmed it yet.

Locally I am using docker-compose v1.29.2, which works with the platform option.

@tuliren tuliren temporarily deployed to more-secrets October 19, 2021 20:26 Inactive
@tuliren tuliren merged commit d9e7bdc into master Oct 19, 2021
@tuliren tuliren deleted the liren/remove-platform-option branch October 19, 2021 20:43
tuliren added a commit that referenced this pull request Oct 19, 2021
tuliren added a commit that referenced this pull request Oct 19, 2021
* Revert "remove platform option temporarily to fix master build (#7184)"

This reverts commit d9e7bdc.

* Test if docker compose works in github action

* Use a dedicated docker compose file for m1

* Restore docker-compose command

* Update comments

* Fix docker compose filename

* Add issue link
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…#7188)

* Revert "remove platform option temporarily to fix master build (airbytehq#7184)"

This reverts commit d9e7bdc.

* Test if docker compose works in github action

* Use a dedicated docker compose file for m1

* Restore docker-compose command

* Update comments

* Fix docker compose filename

* Add issue link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants