Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination databricks: update fields specifications #9153

Merged
merged 5 commits into from
Jan 7, 2022
Merged

🎉 Destination databricks: update fields specifications #9153

merged 5 commits into from
Jan 7, 2022

Conversation

igrankova
Copy link
Contributor

What

Add title and description properties to each field in destination-connectors specifications:
destination-databricks

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova self-assigned this Dec 28, 2021
@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 12:43 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 28, 2021
@igrankova igrankova linked an issue Dec 28, 2021 that may be closed by this pull request
Update fields in destination-connectors specifications: databricks #8948
Closed
@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 12:52 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 28, 2021
@igrankova igrankova temporarily deployed to more-secrets December 28, 2021 12:54 Inactive
@igrankova
Copy link
Contributor Author

igrankova commented Dec 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1630529511
❌ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1630529511
🐛

@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 12:56 Inactive
@igrankova igrankova requested review from annalvova05 and mkhokh-33 and removed request for annalvova05 December 28, 2021 12:57
@mkhokh-33
Copy link
Contributor

hi @sherifnada , @tuliren
Could you please help here
I see from #5998
that "This connector needs to be published as a private image."
Could you please help to publish image here.
Tnx

@tuliren
Copy link
Contributor

tuliren commented Jan 4, 2022

hi @sherifnada , @tuliren Could you please help here I see from #5998 that "This connector needs to be published as a private image." Could you please help to publish image here. Tnx

Once #7622 is merged, we can publish the image with the publish command. That PR was paused for a while, but I will pick it up and finish it, hopefully today.

@tuliren
Copy link
Contributor

tuliren commented Jan 5, 2022

#7622 is delayed by #9298, and the integration test cannot pass. I am still working on it.

@tuliren tuliren mentioned this pull request Jan 7, 2022
Merged
@tuliren
Copy link
Contributor

tuliren commented Jan 7, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666129408
❌ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666129408
🐛

@tuliren
Copy link
Contributor

tuliren commented Jan 7, 2022

Databricks connector is still private, but it can be tested and published as every other connector in PR directly now.

@tuliren tuliren temporarily deployed to more-secrets January 7, 2022 04:28 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 7, 2022 04:29 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 7, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666147057
✅ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666147057
No Python unittests run

@tuliren tuliren temporarily deployed to more-secrets January 7, 2022 04:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets January 7, 2022 04:38 Inactive
@tuliren tuliren changed the title Update fields in destination-connectors specifications: databricks 🎉 Destination databricks: update fields specifications Jan 7, 2022
@tuliren
Copy link
Contributor

tuliren commented Jan 7, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666197109
✅ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1666197109

@jrhizor jrhizor temporarily deployed to more-secrets January 7, 2022 05:02 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 7, 2022

The new version has been published. This connector is currently not publicly available. So the seed does not need to be updated.

@tuliren tuliren merged commit 8237a70 into master Jan 7, 2022
@tuliren tuliren deleted the igrankova/issue-8948-update-title-description branch January 7, 2022 05:16
@jrhizor jrhizor mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren left review comments

@mkhokh-33 mkhokh-33 mkhokh-33 approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees

@mkhokh-33 mkhokh-33

@igrankova igrankova

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databricks connectors/destinations-warehouse
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fields in destination-connectors specifications: databricks
5 participants
@igrankova @mkhokh-33 @tuliren @jrhizor @karinakuz