Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unet3 #907

Merged
merged 34 commits into from
Sep 9, 2021
Merged

Unet3 #907

merged 34 commits into from
Sep 9, 2021

Conversation

lgvaz
Copy link
Collaborator

@lgvaz lgvaz commented Aug 15, 2021

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

lgvaz and others added 29 commits September 8, 2021 11:00
* unet first sketch

* unet missing pieces, dataloader, learner

* freeze learner in adapted_fastai_learner

* adds missing builder template for masks

* change resnet cut to not have avg_pool

* adds semantic segmentation record

* adds SemanticMaskFile

* adds binary parameter to SemanticMaskFile

* testing if can commit to unet branch

* adding segmentation visualization

Co-authored-by: lgvaz <lgvaz42@gmail.com>
Co-authored-by: Lucas Vazquez <lucasgouvaz@gmail.com>
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #907 (4fee8d7) into master (fad6cab) will decrease coverage by 0.94%.
The diff coverage is 78.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   87.51%   86.57%   -0.95%     
==========================================
  Files         235      250      +15     
  Lines        5054     5384     +330     
==========================================
+ Hits         4423     4661     +238     
- Misses        631      723      +92     
Flag Coverage Δ
unittests 86.57% <78.49%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icevision/__init__.py 100.00% <ø> (ø)
icevision/models/mmdet/common/mask/prediction.py 32.60% <ø> (ø)
icevision/models/utils.py 50.68% <7.69%> (-9.32%) ⬇️
icevision/core/components/composite.py 94.23% <16.66%> (-4.75%) ⬇️
...ision/models/torchvision/faster_rcnn/show_batch.py 50.00% <33.33%> (+5.55%) ⬆️
icevision/utils/io.py 37.50% <37.50%> (ø)
...sion/models/fastai/unet/lightning/model_adapter.py 41.37% <41.37%> (ø)
...evision/models/torchvision/mask_rcnn/prediction.py 89.18% <42.85%> (-10.82%) ⬇️
...evision/models/torchvision/mask_rcnn/show_batch.py 46.66% <42.85%> (-53.34%) ⬇️
icevision/visualize/utils.py 64.00% <50.00%> (-12.93%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad6cab...4fee8d7. Read the comment docs.

@lgvaz lgvaz merged commit e60c2e2 into master Sep 9, 2021
@lgvaz lgvaz deleted the unet3 branch September 9, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants