Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define mechanism for managing lifecycle of Labels, Taints post deployment via CAPI Artifacts #3

Open
jezogwza opened this issue Jan 29, 2020 · 69 comments
Open

Define mechanism for managing lifecycle of Labels, Taints post deployment via CAPI Artifacts #3

jezogwza opened this issue Jan 29, 2020 · 69 comments
Assignees
@pramchan
Labels
6-upstream/cluster-api Requires changes in the cluster-api upstream project enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size l
Milestone
Future

Comments

@jezogwza
Copy link
Contributor

Need to go explore if there is a project to manage label, taints, etc for Node .
Community says this is not part of capi for now?
kubernetes-sigs/cluster-api#493

This is a question to define the direction we should take.

Do we create a new operator to do this?
Would this fall under the perview of the Day solution?
@jezogwza jezogwza added question Further information is requested research Research is required, possible a POC and removed question Further information is requested labels Jan 29, 2020
@jezogwza jezogwza added this to the v2.0 milestone Jan 29, 2020
@jezogwza jezogwza modified the milestones: v2.0, postV2.0 Jan 29, 2020
@jezogwza jezogwza changed the title Define mechanism for managing Labels, Taints post deployment Define mechanism for managing lifecycle of Labels, Taints post deployment Jan 29, 2020
@ianpittwood ianpittwood added the help wanted Extra attention is needed label Feb 12, 2020
@jezogwza jezogwza added the triage Needs evaluation by project members label Mar 4, 2020
@jezogwza jezogwza added priority/critical Items critical to be implemented, usually by the next release and removed triage Needs evaluation by project members labels Mar 11, 2020
@jezogwza jezogwza modified the milestones: postV2.0, v2.0 Sep 30, 2020
@jezogwza jezogwza added the design needed New Design or Redesign required label Sep 30, 2020
@airshipbot airshipbot mentioned this issue Oct 1, 2020
Closed
@pramchan
Copy link

To manage Lifecycle of Lables, Taints and PoThis deals with k8s objects NodeSpec and PodSepc.
NodeSpec needs to define taints that will prevent scheduling of node on an agreed label.
PodSpec need to check NodeAffinity through tolerations defined as keyvalue whwre operators can be equal-to , !equal-to etc.
Details are on https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/. Can sloe this with a doc for this.
/assign

@jezogwza jezogwza changed the title Define mechanism for managing lifecycle of Labels, Taints post deployment Define mechanism for managing lifecycle of Labels, Taints post deployment via CAPI Artifacts Oct 27, 2020
@eak13 eak13 mentioned this issue Nov 4, 2020
Closed
@eak13
Copy link

eak13 commented Dec 4, 2020

@Arvinderpal Rodolfo suggested we assign this one to you along with #377 as you may have something in the works. Can you please comment here so I can assign? Thanks!

@eak13 eak13 added enhancement New feature or request and removed design needed New Design or Redesign required help wanted Extra attention is needed research Research is required, possible a POC labels Dec 4, 2020
@Arvinderpal
Copy link
Contributor

Arvinderpal commented Dec 4, 2020 •
edited
Loading

@ak3216 Yes, please assign this to me. The issue kubernetes-sigs/cluster-api#493 is still relevant and is now "open". I hope to get some traction in the capi community to move that forward.

Note that this should not be confused with BMH label syncs: #377

@eak13
Copy link

eak13 commented Dec 4, 2020

Thanks @Arvinderpal . Agree they're different. Added a note in #377 awhile back to make sure they don't get confused.

@eak13 eak13 added the 6-upstream/cluster-api Requires changes in the cluster-api upstream project label Jan 12, 2021
@airshipbot airshipbot assigned pramchan and unassigned Arvinderpal Feb 17, 2021
@airshipbot
Copy link

unassigned: NamedUser(login="pramchan")
assigned: pramchan

@airshipbot
Copy link

unassigned: NamedUser(login="pramchan")
assigned: pramchan

@airshipbot airshipbot assigned pramchan and unassigned pramchan Feb 23, 2021
@airshipbot
Copy link

unassigned: NamedUser(login="pramchan")
assigned: pramchan

@airshipbot airshipbot assigned pramchan and unassigned pramchan Feb 23, 2021
@airshipbot
Copy link

unassigned: NamedUser(login="pramchan")
assigned: pramchan

@airshipbot airshipbot assigned pramchan and unassigned pramchan Feb 23, 2021
@airshipbot
Copy link

unassigned: NamedUser(login="pramchan")
assigned: pramchan

@eak13 eak13 assigned Arvinderpal and unassigned pramchan Feb 23, 2021
@airshipbot
Copy link

Unable to assign pramchan. Please contact a member of the @airshipit/airship-cores team for help with assignments.

1 similar comment
@airshipbot
Copy link

Unable to assign pramchan. Please contact a member of the @airshipit/airship-cores team for help with assignments.

@airshipbot airshipbot assigned pramchan and unassigned Arvinderpal Feb 23, 2021
@airshipbot
Copy link

unassigned: NamedUser(login="Arvinderpal")
assigned: pramchan

@sirajyasin
Copy link
Contributor

Sorry for the comments from BOT on this issue. It was wrongly updated due to an issue in the BOT. We are working to resolve the BOT issue and will update here once resolved.

@eak13 eak13 added the size l label Mar 1, 2021
@lb4368 lb4368 modified the milestones: v2.0, v2.1 Mar 29, 2021
@lb4368 lb4368 modified the milestones: v2.1, Future Apr 26, 2021
@jgu17 jgu17 mentioned this issue May 5, 2021
Closed
@mattmceuen
Copy link
Contributor

For the Label part of this, it should be covered by the recently added M3 (0.4.2) support for label management, I believe. There is a spike story out there to verify this: #615

For for the Taint part, I'm not sure that it's priority; this would be a nice feature but I'm not sure whether we have an immediate use case for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pramchan pramchan

Labels
6-upstream/cluster-api Requires changes in the cluster-api upstream project enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size l
Projects
None yet
Milestone
Future
Development

No branches or pull requests
9 participants
@lb4368 @pramchan @eak13 @mattmceuen @jezogwza @Arvinderpal @ianpittwood @sirajyasin @airshipbot