Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replacements for composite/infra #549

Closed
mattmceuen opened this issue May 24, 2021 · 1 comment
Closed

Add replacements for composite/infra #549

mattmceuen opened this issue May 24, 2021 · 1 comment
Assignees
Labels
bug Something isn't working priority/medium Default priority for items size m
Milestone

Comments

@mattmceuen
Copy link
Contributor

As it stands today:

  • the cert-manager function doesn't specify any /replacements
  • the tigera-operator function has /replacements, but they're not getting used anywhere afaict

In order to ensure proper replacement of container image refs, this story is to implement the following:

  1. add the three images used in the cert-manager function to airshipctl-base-catalogues/airshipctl-versions.yaml.
  2. there is a single cert-manager entry in that catalogue already, which looks to be unneeded and should be removed. The existing field is referenced by a mapping rule in function/clusterctl/replacements, which is no longer relevant and should be removed.
  3. add a cert-manager/v1.1.0/replacements kustomization, which allows replacement of cert-manager container images from the versions catalogue
  4. create a composite/infra/replacements entrypoint which aggregates the cert-manager replacements and the tigera-operator replacements
  5. anywhere the composite/infra is referenced, in airshipctl or treasuremap, make sure the new composite/infra/replacements is pulled in as appropriate. At the type level, that probably means referencing the new replacements in initinfra/replacements. If there is a test-site site-level reference to composite/infra in airshipctl, then the replacements should be applied in that same kustomization.yaml.
@mattmceuen mattmceuen added bug Something isn't working triage Needs evaluation by project members priority/medium Default priority for items and removed triage Needs evaluation by project members labels May 24, 2021
@mattmceuen mattmceuen added this to the Future milestone May 26, 2021
@sirajyasin
Copy link
Contributor

I can start working on this issue. can someone assign this to me

@eak13 eak13 added the size m label Jun 3, 2021
@lb4368 lb4368 modified the milestones: Future, v2.1 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium Default priority for items size m
Projects
None yet
Development

No branches or pull requests

4 participants