Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remoteRef Configuration Option for Use in Document Pull #616

Closed
lb4368 opened this issue Jul 16, 2021 · 2 comments
Closed

Implement remoteRef Configuration Option for Use in Document Pull #616

lb4368 opened this issue Jul 16, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request priority/medium Default priority for items size m
Milestone

Comments

@lb4368
Copy link

lb4368 commented Jul 16, 2021

Problem description
For development/debugging purposes it would be useful to be able to specify to check out a gerrit patchset as part of an 'airshipctl document pull' configuration. There is a remoteRef attribute available in the repository checkout section of the airship configuration file that is intended to allow specification of a git reference to be checked out as part of the document pull. However, this option is currently not implemented.

Proposed change
Update the airshipctl document pull functionality to checkout the git reference specified in the remoteRef configuration option if it is specified.

@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Jul 16, 2021
@manojkva
Copy link
Contributor

Please assign this to me. Thanks

@eak13 eak13 added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Jul 21, 2021
@eak13 eak13 added this to the v2.1 milestone Jul 21, 2021
@manojkva
Copy link
Contributor

Had a discussion with Ruslan Aliev and here are his comments
"that's a complicated issue, talks about supporting remoteRef were started 1.5 years ago and still there is no solution. there are limitations and complication in go-git module, there is need to deep dive into go-git api, gerrit refs and so on, I can't give any clues unfortunately, it requires a complete research, if it were easy this functionality would have been implemented long ago"

I think this will need a design discussion and would need research.

@manojkva manojkva removed their assignment Jul 23, 2021
@ian-howell ian-howell self-assigned this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Default priority for items size m
Projects
None yet
Development

No branches or pull requests

4 participants