Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIAP: Using the .git suffix on repository names causes runner pod failure #653

Closed
drewwalters96 opened this issue Oct 7, 2021 · 2 comments
Closed

AIAP: Using the .git suffix on repository names causes runner pod failure #653

drewwalters96 opened this issue Oct 7, 2021 · 2 comments
Assignees
@sirajyasin
Labels
bug Something isn't working priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Milestone
v2.1

Comments

@drewwalters96
Copy link
Contributor

Describe the bug
Sometimes the .git suffix is included in repository URLs, e.g. https://github.com/airshipit/airshipctl.git. Because AIAP parses the end of the repository URL when creating directories, the .git suffix can incidentally be included in some but not all directory paths.

+ cp /opt/manifests/airshipctl.git/manifests/.private-keys/my.key /opt/manifests/airshipctl.git/manifests/.private-keys/my.key.old
Sanity check 1: Check that we can decrypt everything with U1 and U2 creds
cp: cannot stat '/opt/manifests/airshipctl.git/manifests/.private-keys/my.key': No such file or directory

Steps To Reproduce
Change the airshipctl manifest repo url to https://github.com/airshipit/airshipctl.git and run.

Expected behavior
AIAP should ignore the .git suffix when creating paths.
@drewwalters96 drewwalters96 added bug Something isn't working triage Needs evaluation by project members labels Oct 7, 2021
@jezogwza jezogwza added priority/low Items that are considered non-critical for functionality, such as quality of life improvements and removed triage Needs evaluation by project members labels Oct 13, 2021
@jezogwza jezogwza added this to the v2.2 milestone Oct 13, 2021
@sirajyasin
Copy link
Contributor

I can work on this issue if no one has started yet. can someone assign this issue to me

@sreejithpunnapuzha
Copy link
Member

All yours @sirajyasin

@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirajyasin sirajyasin

Labels
bug Something isn't working priority/low Items that are considered non-critical for functionality, such as quality of life improvements
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
5 participants
@eak13 @jezogwza @drewwalters96 @sirajyasin @sreejithpunnapuzha