Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another representation for ratio column when benchmarking #952

Closed
YarShev opened this issue Dec 4, 2020 · 1 comment
Closed

Another representation for ratio column when benchmarking #952

YarShev opened this issue Dec 4, 2020 · 1 comment

Comments

@YarShev
Copy link

YarShev commented Dec 4, 2020

Hi there,

After I tried asv for my needs, I saw that ratio column is relation after to before (I mean ratio=after/before) based on the output:

       before           after         ratio
     [74587461]       [0c9b56d0]
     <master>         <internal-error>
!        62910ms           failed      n/a  benchmarks.TimeBinaryOp.time_concat('int', (10128, 100, 10000, 128), 'mul', 1)
-         2663ms          1332ms     0.50  benchmarks.TimeConcat.time_concat('int', (10128, 100, 10000, 128), 'inner', 1)
-      1.130.01s          1415ms     0.12  benchmarks.TimeConcat.time_concat('int', (10128, 100, 10000, 128), 'inner', 0)

I think it's better to use ratio=before/after in order to showcase speed up or slowdown for an operation. At least wherever I saw ratio=before/after notation is used. Is it possible to change representation of ratio column?

Thanks in advance for attention!

@HaoZeke
Copy link
Member

HaoZeke commented Aug 12, 2024

I think there's no real good answer to this, other than that the conventions are now documented better #1421. It isn't always before after, it could just be commit1 and altcommit1 and swapping them in the CLI would give the conventional view point as well. A PR would be the next step for a discussion on this, especially since the mark parameter is currently a bit overloaded in terms of ' '.

@HaoZeke HaoZeke closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants